CCM-17639: Publish DigitalLettersUnsuccessfulEvent#339
Open
ScottFullerton-NHSE wants to merge 19 commits into
Open
CCM-17639: Publish DigitalLettersUnsuccessfulEvent#339ScottFullerton-NHSE wants to merge 19 commits into
ScottFullerton-NHSE wants to merge 19 commits into
Conversation
This was referenced May 13, 2026
simonlabarere
previously approved these changes
May 14, 2026
Contributor
simonlabarere
left a comment
simonlabarere
left a comment
There was a problem hiding this comment.
First pass of a review. I haven't had a look at the tests yet.
Contributor
simonlabarere
left a comment
simonlabarere
left a comment
There was a problem hiding this comment.
We probably want to add and/or update playwright tests for this.
Ian-Hodges
reviewed
May 19, 2026
Ian-Hodges
previously approved these changes
May 19, 2026
Ian-Hodges
previously approved these changes
May 20, 2026
…lish-unsuccessful-events # Conflicts: # lambdas/nhsapp-status-handler/src/infra/config.ts
Ian-Hodges
reviewed
May 21, 2026
simonlabarere
previously approved these changes
May 21, 2026
Ian-Hodges
previously approved these changes
May 21, 2026
ScottFullerton-NHSE
dismissed stale reviews from Ian-Hodges and simonlabarere
via
74520e9
Ian-Hodges
approved these changes
May 22, 2026
simonlabarere
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.